Do not reset globals when set as returnvalues#493
Do not reset globals when set as returnvalues#493kkoopa wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Is there a test scenario that can reproduce the bug and verify that it is fixed? I am happy to contribute the test scenario if you like. |
|
I don't think there is one, but I don't know how to test this either. The thing is that NAN_METHOD(foo) {
info.GetReturnValue().Set(Nan::Global<v8::Value>(Nan::New(4)));
}The So it would need to test that there are no memory leaks and no use-after-frees. Also, 78fa1c4 should be included. |
|
To be honest Hoping to see your fixes land soon. |
|
Yeah, holding off on this right now due to the risks of introducing new problems. Will do some manual testing at some point to get these properly integrated. |
|
This should go in 2.4 |
No description provided.